Fix DictSupplementaryFileContainer: refcount never incremented, delete_file never frees memory#513
Merged
Conversation
s-heppner
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #495
Changes
_assign_unique_name: increment_store_refcount[sha]when creating a new_name_mapentry (first loop branch) — without this, count stays at 0 anddelete_file's== 0check never triggersrename_file: decrement_store_refcount[file_hash]when removing the old name entry from_name_map, consistent withdelete_filebehaviortest_supplementary_file_container_refcount— verifies backing store is freed only after the last reference is deleted